cedry2k1992andClaude Sonnet 5
e4fa57c3d6
Run-all buttons (per target and per investigation) queue every applicable, not-already-in-flight source via a new FindingDispatcher, re-attempting prior failures automatically. RunFinding now applies a per-source RateLimited queue middleware so a bulk run can't hammer the free public APIs (ip-api, crt.sh, whois, sherlock, theharvester) it depends on; $tries raised to 30 to survive rate-limiter releases, with a failed() handler so exhausted retries still resolve the Finding instead of leaving it stuck pending. Also fixes CrtShRunner treating crt.sh's intermittent 404/502 (a known flaky free service) as fatal on the first try — added a bounded retry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
47 lines
1.9 KiB
PHP
47 lines
1.9 KiB
PHP
<?php
|
|
|
|
namespace Tests\Unit\Jobs;
|
|
|
|
use App\Jobs\RunFinding;
|
|
use App\Models\Finding;
|
|
use App\Models\Investigation;
|
|
use App\Models\Source;
|
|
use App\Models\User;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Queue\Middleware\RateLimited;
|
|
use Tests\TestCase;
|
|
|
|
class RunFindingTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_middleware_rate_limits_by_the_findings_source_key(): void
|
|
{
|
|
$user = User::factory()->create();
|
|
$investigation = Investigation::factory()->for($user, 'owner')->create();
|
|
$target = $investigation->targets()->create(['type' => 'ip', 'value' => '8.8.8.8', 'created_by' => $user->id]);
|
|
$source = Source::create(['key' => 'ip-api', 'name' => 'ip-api.com', 'target_types' => ['ip'], 'enabled' => true]);
|
|
$finding = $target->findings()->create(['source_id' => $source->id, 'status' => 'pending']);
|
|
|
|
$middleware = (new RunFinding($finding->id))->middleware();
|
|
|
|
$this->assertCount(1, $middleware);
|
|
$this->assertInstanceOf(RateLimited::class, $middleware[0]);
|
|
}
|
|
|
|
public function test_failed_marks_the_finding_as_failed(): void
|
|
{
|
|
$user = User::factory()->create();
|
|
$investigation = Investigation::factory()->for($user, 'owner')->create();
|
|
$target = $investigation->targets()->create(['type' => 'ip', 'value' => '8.8.8.8', 'created_by' => $user->id]);
|
|
$source = Source::create(['key' => 'ip-api', 'name' => 'ip-api.com', 'target_types' => ['ip'], 'enabled' => true]);
|
|
$finding = $target->findings()->create(['source_id' => $source->id, 'status' => 'pending']);
|
|
|
|
(new RunFinding($finding->id))->failed(new \RuntimeException('retries exhausted'));
|
|
|
|
$finding->refresh();
|
|
$this->assertSame('failed', $finding->status);
|
|
$this->assertStringContainsString('retries exhausted', $finding->error);
|
|
}
|
|
}
|