Files
fitness/app/Http/Controllers/WorkoutController.php
T
rootandClaude Sonnet 5 e8173ff90a Build out the trainer role
is_trainer was captured at signup and stored, but nothing in the app
used it - no client roster, no way to assign anything, a dead flag that
misled users who checked it during registration.

Adds a trainer/client link (a trainer adds a client by the email they
registered with) and lets a trainer create workouts directly on a
client's account (assigned_by_trainer_id on workouts). Deliberately
scoped for privacy: a trainer only ever sees/manages the workouts they
authored and assigned - not a client's other private data (their own
workouts, weight log, health notes, session/completion history). That
boundary needs a consent or notification system to relax safely, which
doesn't exist yet, so it's left for a follow-up rather than building it
half-safe.

WorkoutController's authorization now distinguishes "manage" (owner or
assigning trainer - view, add/edit exercises) from "own" (owner only -
delete), so a trainer can build out an assigned workout's exercises
after creating it, but can't delete a client's workout out from under
them.

Found a real bug via live testing before committing: the client roster
page eager-loaded `assignedWorkouts` (keyed by assigned_by_trainer_id)
on each client record, which is the trainer's own perspective, not the
client's - so it silently showed "no workouts assigned" even after
assigning one. Fixed to eager-load `workouts` filtered by
assigned_by_trainer_id instead, with a regression test.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-10 12:28:23 +03:00

137 lines
4.6 KiB
PHP

<?php
namespace App\Http\Controllers;
use App\Models\Exercise;
use App\Models\Workout;
use App\Models\WorkoutExercise;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
class WorkoutController extends Controller
{
public function __construct()
{
//$this->middleware('auth');
}
public function index()
{
$workouts = Auth::user()->workouts()->with('assignedByTrainer')->latest()->paginate(10);
return view('workouts.index', compact('workouts'));
}
public function create()
{
// Simple create form (builder-like)
return view('workouts.create');
}
public function store(Request $request)
{
$data = $request->validate([
'title' => 'required|string|max:255',
'notes' => 'nullable|string',
'estimated_minutes' => 'nullable|integer|min:1|max:600',
]);
$workout = Auth::user()->workouts()->create($data);
return redirect()->route('workouts.show', $workout)->with('status', 'Workout created');
}
public function show(Workout $workout)
{
$this->authorizeWorkout($workout);
$workout->load(['items.exercise', 'assignedByTrainer']);
$exercises = Exercise::orderBy('name')->limit(20)->get(['id','name','slug']);
return view('workouts.show', compact('workout', 'exercises'));
}
public function searchExercises(Request $request, Workout $workout)
{
$this->authorizeWorkout($workout);
$q = trim((string) $request->query('q', ''));
$exercises = Exercise::query()
->with(['aliases' => fn ($rel) => $rel->where('user_id', Auth::id())])
->when($q !== '', fn ($qb) => $qb->where('name', 'like', "%{$q}%"))
->orderBy('name')
->limit(20)
->get(['id', 'name'])
->map(fn ($e) => ['id' => $e->id, 'name' => $e->display_name]);
return response()->json($exercises);
}
// Legacy builder route -> redirect to create
public function builder()
{
return redirect()->route('workouts.create');
}
public function addExercise(Request $request, Workout $workout)
{
$this->authorizeWorkout($workout);
$data = $request->validate([
'exercise_id' => 'required|exists:exercises,id',
'position' => 'nullable|integer|min:1',
'sets' => 'nullable|integer|min:1|max:20',
'reps' => 'nullable|integer|min:1|max:200',
'weight' => 'nullable|numeric|min:0|max:999.99',
'rest_seconds' => 'nullable|integer|min:0|max:600',
'notes' => 'nullable|string',
]);
$nextPos = ($workout->items()->max('position') ?? 0) + 1;
$data['position'] = $data['position'] ?? $nextPos;
$item = $workout->items()->create($data);
return back()->with('status', 'Exercise added to workout');
}
public function updateExercise(Request $request, Workout $workout, WorkoutExercise $item)
{
$this->authorizeWorkout($workout);
if ($item->workout_id !== $workout->id) { abort(404); }
$data = $request->validate([
'position' => 'nullable|integer|min:1',
'sets' => 'nullable|integer|min:1|max:20',
'reps' => 'nullable|integer|min:1|max:200',
'weight' => 'nullable|numeric|min:0|max:999.99',
'rest_seconds' => 'nullable|integer|min:0|max:600',
'notes' => 'nullable|string',
]);
$item->update($data);
return back()->with('status', 'Exercise updated');
}
public function removeExercise(Workout $workout, WorkoutExercise $item)
{
$this->authorizeWorkout($workout);
if ($item->workout_id !== $workout->id) { abort(404); }
$item->delete();
return back()->with('status', 'Exercise removed');
}
public function destroy(Workout $workout)
{
// Deletion stays strictly owner-only, even for a trainer-assigned workout.
if ($workout->user_id !== Auth::id()) {
abort(403);
}
$workout->delete();
return redirect()->route('workouts.index')->with('status', 'Workout deleted');
}
// Allows the owner, or the trainer who assigned this workout, to view and edit it.
// Session/completion data is intentionally not exposed to the trainer here - only
// the workout structure they authored.
protected function authorizeWorkout(Workout $workout): void
{
if ($workout->user_id === Auth::id()) {
return;
}
if ($workout->assigned_by_trainer_id && $workout->assigned_by_trainer_id === Auth::id()) {
return;
}
abort(403);
}
}