root/thecrimesynticate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address final review findings — nerve consume ordering, character init, seeder costs, dead column

Browse Source 
- Consume nerve before energy in CrimeService so energy is never lost when nerve is insufficient
- Initialize nerve/max_nerve from config in CharacterController::store (same pattern as energy/health)
- Add nerve_cost to all CrimeSeeder entries proportional to difficulty (1-5 range)
- Remove nerve_regen_at from Character $fillable/$casts/@property — column exists but is not yet wired up

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Doar Mihai
2026-06-28 17:09:21 +03:00
co-authored by Claude Sonnet 4.6
parent 439f6740c0
commit 3e6a84503d
4 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Services/Game/CrimeService.php
+5 -5
View File
@@ -37,16 +37,16 @@ class CrimeService
throw new \Exception('Character cannot perform actions right now.');
}
// Consume nerve first so energy is never deducted if nerve is insufficient
if (!$this->nerveService->consume($character, $crime->nerve_cost)) {
throw new \Exception('Not enough nerve to attempt this crime.');
}
// Consume energy
if (!$this->energyService->consume($character, $crime->energy_cost, 'crime')) {
throw new \Exception('Not enough energy to attempt this crime.');
}
// Consume nerve
if (!$this->nerveService->consume($character, $crime->nerve_cost)) {
throw new \Exception('Not enough nerve to attempt this crime.');
}
// Calculate success rate
$successRate = $crime->calculateSuccessRate($character);
$isSuccess = random_int(0, 9999) / 10000 <= $successRate;