StepHandler abstraction (app/Support/VideoWorkflow/StepHandlers/) plugs into WorkflowEngine without coupling it to how any given step type is actually executed: - ScriptGenerationHandler: builds a prompt from the project's title/ description (or an explicit outline/tone/keywords/target length in step input), generates via an active OpenAI AiProvider, stores the result as a 'script' asset. - TtsVoiceoverHandler: voices step.input.text, or falls back to the project's latest script asset, via an active ElevenLabs AiProvider; voice_id/model_id are configurable per step. No direct "speed" control — ElevenLabs' base TTS endpoint doesn't expose one. RunWorkflowStepJob resolves a step's handler by type and runs it on the queue, matching the existing PublishPostJob pattern (including a stale-dispatch guard: no-op if the step isn't 'in_progress' anymore). UI, under its own /video-projects routes and nav entry — separate from /projects per the earlier decision: - VideoProjects/Index (#43): list projects with status and step progress, create new ones. - VideoProjects/Show (#44): start a project from a WorkflowTemplate or a hardcoded default 8-step pipeline; per-step Run/Approve/Reject/ Retry/Skip actions; auto-queues the next step after any transition when a handler exists for its type (steps with no handler yet just sit in_progress rather than auto-failing); lists project assets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,77 @@
|
||||
<?php
|
||||
|
||||
use App\Jobs\RunWorkflowStepJob;
|
||||
use App\Models\AiProvider;
|
||||
use App\Models\VideoProject;
|
||||
use App\Support\AiProviders\AiProviderManager;
|
||||
use App\Support\VideoWorkflow\StepHandlers\StepHandlerManager;
|
||||
use App\Support\VideoWorkflow\WorkflowEngine;
|
||||
use Illuminate\Support\Facades\Http;
|
||||
use Illuminate\Support\Facades\Storage;
|
||||
|
||||
beforeEach(function () {
|
||||
Storage::fake();
|
||||
$this->engine = new WorkflowEngine;
|
||||
});
|
||||
|
||||
test('it runs the matching handler and completes the step', function () {
|
||||
Http::fake(['api.openai.com/*' => Http::response(['choices' => [['message' => ['content' => 'a script']]]])]);
|
||||
AiProvider::factory()->create(['provider' => 'openai']);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'script_generation']]);
|
||||
|
||||
(new RunWorkflowStepJob($step->id))->handle(app(StepHandlerManager::class), $this->engine);
|
||||
|
||||
expect($step->fresh()->status)->toBe('completed');
|
||||
});
|
||||
|
||||
test('it fails the step when no handler is registered for its type', function () {
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'video_generation']]);
|
||||
|
||||
(new RunWorkflowStepJob($step->id))->handle(app(StepHandlerManager::class), $this->engine);
|
||||
|
||||
expect($step->fresh())
|
||||
->status->toBe('failed')
|
||||
->error->toContain('No handler registered');
|
||||
});
|
||||
|
||||
test('it does nothing for a step that is no longer in_progress', function () {
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'script_generation']]);
|
||||
$this->engine->skipStep($step);
|
||||
|
||||
(new RunWorkflowStepJob($step->id))->handle(app(StepHandlerManager::class), $this->engine);
|
||||
|
||||
expect($step->fresh()->status)->toBe('skipped');
|
||||
});
|
||||
|
||||
test('it does nothing for a missing step', function () {
|
||||
(new RunWorkflowStepJob(999999))->handle(app(StepHandlerManager::class), $this->engine);
|
||||
})->throwsNoExceptions();
|
||||
|
||||
test('it fails the step when the handler throws unexpectedly', function () {
|
||||
$badHandler = new class implements \App\Support\VideoWorkflow\StepHandlers\StepHandler
|
||||
{
|
||||
public function type(): string
|
||||
{
|
||||
return 'script_generation';
|
||||
}
|
||||
|
||||
public function handle(\App\Models\WorkflowStep $step, WorkflowEngine $engine): void
|
||||
{
|
||||
throw new \RuntimeException('boom');
|
||||
}
|
||||
};
|
||||
$manager = new StepHandlerManager([$badHandler]);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'script_generation']]);
|
||||
|
||||
(new RunWorkflowStepJob($step->id))->handle($manager, $this->engine);
|
||||
|
||||
expect($step->fresh())
|
||||
->status->toBe('failed')
|
||||
->error->toBe('boom');
|
||||
});
|
||||
@@ -0,0 +1,54 @@
|
||||
<?php
|
||||
|
||||
use App\Livewire\VideoProjects\Index;
|
||||
use App\Models\User;
|
||||
use App\Models\VideoProject;
|
||||
use App\Support\VideoWorkflow\WorkflowEngine;
|
||||
use Livewire\Livewire;
|
||||
|
||||
test('video projects index page lists existing projects', function () {
|
||||
VideoProject::factory()->create(['title' => 'My Awesome Video']);
|
||||
|
||||
$this->actingAs(User::factory()->create())
|
||||
->get(route('video-projects.index'))
|
||||
->assertOk()
|
||||
->assertSee('My Awesome Video');
|
||||
});
|
||||
|
||||
test('a new video project can be created', function () {
|
||||
Livewire::test(Index::class)
|
||||
->set('title', 'New Video')
|
||||
->set('description', 'A description')
|
||||
->call('save');
|
||||
|
||||
expect(VideoProject::where('title', 'New Video')->exists())->toBeTrue();
|
||||
});
|
||||
|
||||
test('title is required to create a video project', function () {
|
||||
Livewire::test(Index::class)
|
||||
->set('title', '')
|
||||
->call('save')
|
||||
->assertHasErrors(['title']);
|
||||
});
|
||||
|
||||
test('a video project can be deleted', function () {
|
||||
$project = VideoProject::factory()->create();
|
||||
|
||||
Livewire::test(Index::class)->call('delete', $project->id);
|
||||
|
||||
expect(VideoProject::find($project->id))->toBeNull();
|
||||
});
|
||||
|
||||
test('it shows step progress counts for a started project', function () {
|
||||
$project = VideoProject::factory()->create(['title' => 'Progress Test']);
|
||||
$engine = new WorkflowEngine;
|
||||
$step = $engine->start($project, [
|
||||
['type' => 'script_generation'],
|
||||
['type' => 'tts_voiceover'],
|
||||
]);
|
||||
$engine->completeStep($step);
|
||||
|
||||
$this->actingAs(User::factory()->create())
|
||||
->get(route('video-projects.index'))
|
||||
->assertSee('1 / 2');
|
||||
});
|
||||
@@ -0,0 +1,129 @@
|
||||
<?php
|
||||
|
||||
use App\Jobs\RunWorkflowStepJob;
|
||||
use App\Livewire\VideoProjects\Show;
|
||||
use App\Models\VideoProject;
|
||||
use App\Models\WorkflowTemplate;
|
||||
use App\Support\VideoWorkflow\WorkflowEngine;
|
||||
use Illuminate\Support\Facades\Queue;
|
||||
use Livewire\Livewire;
|
||||
|
||||
test('starting the default pipeline creates steps and queues the first handled one', function () {
|
||||
Queue::fake();
|
||||
$project = VideoProject::factory()->create();
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->call('startDefault');
|
||||
|
||||
expect($project->fresh()->status)->toBe('in_progress');
|
||||
expect($project->steps()->count())->toBe(8);
|
||||
expect($project->steps()->orderBy('order')->first()->type)->toBe('script_generation');
|
||||
|
||||
Queue::assertPushed(RunWorkflowStepJob::class, function ($job) use ($project) {
|
||||
$step = $project->steps()->orderBy('order')->first();
|
||||
|
||||
return $job->stepId === $step->id;
|
||||
});
|
||||
});
|
||||
|
||||
test('starting from a template uses its steps and does not queue unhandled types', function () {
|
||||
Queue::fake();
|
||||
$template = WorkflowTemplate::factory()->create(['steps' => [
|
||||
['type' => 'video_generation'],
|
||||
['type' => 'youtube_publish'],
|
||||
]]);
|
||||
$project = VideoProject::factory()->create();
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->set('workflowTemplateId', $template->id)
|
||||
->call('startWithTemplate');
|
||||
|
||||
expect($project->fresh()->workflow_template_id)->toBe($template->id);
|
||||
expect($project->steps()->count())->toBe(2);
|
||||
|
||||
// video_generation has no handler yet, so nothing should be queued
|
||||
Queue::assertNotPushed(RunWorkflowStepJob::class);
|
||||
});
|
||||
|
||||
test('startWithTemplate shows a notice when no template is selected', function () {
|
||||
$project = VideoProject::factory()->create();
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->call('startWithTemplate')
|
||||
->assertSee('Pick a template first.');
|
||||
|
||||
expect($project->fresh()->status)->toBe('draft');
|
||||
});
|
||||
|
||||
test('runStep dispatches the job for the given step', function () {
|
||||
Queue::fake();
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = (new WorkflowEngine)->start($project, [['type' => 'script_generation']]);
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->call('runStep', $step->id);
|
||||
|
||||
Queue::assertPushed(RunWorkflowStepJob::class, fn ($job) => $job->stepId === $step->id);
|
||||
});
|
||||
|
||||
test('approving a step advances and queues the next handled step', function () {
|
||||
Queue::fake();
|
||||
$project = VideoProject::factory()->create();
|
||||
$engine = new WorkflowEngine;
|
||||
$step = $engine->start($project, [
|
||||
['type' => 'script_generation', 'requires_approval' => true],
|
||||
['type' => 'tts_voiceover'],
|
||||
]);
|
||||
$engine->completeStep($step, ['script' => 'draft']);
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->call('approveStep', $step->id);
|
||||
|
||||
$next = $project->steps()->where('order', 1)->first();
|
||||
expect($next->status)->toBe('in_progress');
|
||||
Queue::assertPushed(RunWorkflowStepJob::class, fn ($job) => $job->stepId === $next->id);
|
||||
});
|
||||
|
||||
test('rejecting a step blocks the pipeline', function () {
|
||||
$project = VideoProject::factory()->create();
|
||||
$engine = new WorkflowEngine;
|
||||
$step = $engine->start($project, [['type' => 'script_generation', 'requires_approval' => true]]);
|
||||
$engine->completeStep($step, ['script' => 'bad']);
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->call('rejectStep', $step->id);
|
||||
|
||||
expect($step->fresh()->status)->toBe('rejected');
|
||||
});
|
||||
|
||||
test('retrying a failed step re-queues it', function () {
|
||||
Queue::fake();
|
||||
$project = VideoProject::factory()->create();
|
||||
$engine = new WorkflowEngine;
|
||||
$step = $engine->start($project, [['type' => 'script_generation']]);
|
||||
$engine->failStep($step, 'boom');
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->call('retryStep', $step->id);
|
||||
|
||||
expect($step->fresh()->status)->toBe('in_progress');
|
||||
Queue::assertPushed(RunWorkflowStepJob::class, fn ($job) => $job->stepId === $step->id);
|
||||
});
|
||||
|
||||
test('skipping a step advances and queues the next handled step', function () {
|
||||
Queue::fake();
|
||||
$project = VideoProject::factory()->create();
|
||||
$engine = new WorkflowEngine;
|
||||
$step = $engine->start($project, [
|
||||
['type' => 'video_generation'],
|
||||
['type' => 'script_generation'],
|
||||
]);
|
||||
|
||||
Livewire::test(Show::class, ['videoProject' => $project])
|
||||
->call('skipStep', $step->id);
|
||||
|
||||
$next = $project->steps()->where('order', 1)->first();
|
||||
expect($step->fresh()->status)->toBe('skipped');
|
||||
expect($next->status)->toBe('in_progress');
|
||||
Queue::assertPushed(RunWorkflowStepJob::class, fn ($job) => $job->stepId === $next->id);
|
||||
});
|
||||
@@ -0,0 +1,91 @@
|
||||
<?php
|
||||
|
||||
use App\Models\AiProvider;
|
||||
use App\Models\VideoProject;
|
||||
use App\Support\AiProviders\AiProviderManager;
|
||||
use App\Support\AssetStorage\AssetStorage;
|
||||
use App\Support\VideoWorkflow\StepHandlers\ScriptGenerationHandler;
|
||||
use App\Support\VideoWorkflow\WorkflowEngine;
|
||||
use Illuminate\Support\Facades\Http;
|
||||
use Illuminate\Support\Facades\Storage;
|
||||
|
||||
beforeEach(function () {
|
||||
Storage::fake();
|
||||
$this->engine = new WorkflowEngine;
|
||||
$this->handler = new ScriptGenerationHandler(app(AiProviderManager::class), new AssetStorage);
|
||||
});
|
||||
|
||||
test('it generates a script, stores it as an asset, and completes the step', function () {
|
||||
Http::fake([
|
||||
'api.openai.com/*' => Http::response([
|
||||
'choices' => [['message' => ['content' => 'Welcome back to the channel today']]],
|
||||
]),
|
||||
]);
|
||||
AiProvider::factory()->create(['provider' => 'openai', 'is_active' => true]);
|
||||
|
||||
$project = VideoProject::factory()->create(['title' => 'Best Coffee Gadgets 2026']);
|
||||
$step = $this->engine->start($project, [['type' => 'script_generation']]);
|
||||
|
||||
$this->handler->handle($step, $this->engine);
|
||||
|
||||
$fresh = $step->fresh();
|
||||
expect($fresh->status)->toBe('completed');
|
||||
expect($fresh->output['word_count'])->toBe(6);
|
||||
|
||||
$asset = \App\Models\Asset::find($fresh->output['asset_id']);
|
||||
expect($asset->type)->toBe('script');
|
||||
expect($asset->video_project_id)->toBe($project->id);
|
||||
expect(Storage::get($asset->disk_path))->toBe('Welcome back to the channel today');
|
||||
|
||||
Http::assertSent(fn ($request) => str_contains($request['messages'][0]['content'], 'Best Coffee Gadgets 2026'));
|
||||
});
|
||||
|
||||
test('it uses an explicit outline, tone, keywords, and target length when given', function () {
|
||||
Http::fake(['api.openai.com/*' => Http::response(['choices' => [['message' => ['content' => 'script']]]])]);
|
||||
AiProvider::factory()->create(['provider' => 'openai']);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'script_generation']]);
|
||||
$step->update(['input' => [
|
||||
'outline' => 'A history of espresso machines',
|
||||
'tone' => 'casual and funny',
|
||||
'seo_keywords' => ['espresso', 'coffee history'],
|
||||
'target_words' => 800,
|
||||
]]);
|
||||
|
||||
$this->handler->handle($step->fresh(), $this->engine);
|
||||
|
||||
Http::assertSent(function ($request) {
|
||||
$prompt = $request['messages'][0]['content'];
|
||||
|
||||
return str_contains($prompt, 'A history of espresso machines')
|
||||
&& str_contains($prompt, 'casual and funny')
|
||||
&& str_contains($prompt, 'espresso, coffee history')
|
||||
&& str_contains($prompt, 'approximately 800 words');
|
||||
});
|
||||
});
|
||||
|
||||
test('it fails the step when no active OpenAI provider is configured', function () {
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'script_generation']]);
|
||||
|
||||
$this->handler->handle($step, $this->engine);
|
||||
|
||||
expect($step->fresh())
|
||||
->status->toBe('failed')
|
||||
->error->toContain('No active OpenAI provider');
|
||||
});
|
||||
|
||||
test('it fails the step when the AI provider call fails', function () {
|
||||
Http::fake(['api.openai.com/*' => Http::response(['error' => ['message' => 'rate limited']], 429)]);
|
||||
AiProvider::factory()->create(['provider' => 'openai']);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'script_generation']]);
|
||||
|
||||
$this->handler->handle($step, $this->engine);
|
||||
|
||||
expect($step->fresh())
|
||||
->status->toBe('failed')
|
||||
->error->toBe('rate limited');
|
||||
});
|
||||
@@ -0,0 +1,92 @@
|
||||
<?php
|
||||
|
||||
use App\Models\AiProvider;
|
||||
use App\Models\VideoProject;
|
||||
use App\Support\AiProviders\AiProviderManager;
|
||||
use App\Support\AssetStorage\AssetStorage;
|
||||
use App\Support\VideoWorkflow\StepHandlers\TtsVoiceoverHandler;
|
||||
use App\Support\VideoWorkflow\WorkflowEngine;
|
||||
use Illuminate\Support\Facades\Http;
|
||||
use Illuminate\Support\Facades\Storage;
|
||||
|
||||
beforeEach(function () {
|
||||
Storage::fake();
|
||||
$this->engine = new WorkflowEngine;
|
||||
$this->assets = new AssetStorage;
|
||||
$this->handler = new TtsVoiceoverHandler(app(AiProviderManager::class), $this->assets);
|
||||
});
|
||||
|
||||
test('it voices explicit input text and completes the step', function () {
|
||||
Http::fake(['api.elevenlabs.io/*' => Http::response('fake-mp3-bytes', 200, ['Content-Type' => 'audio/mpeg'])]);
|
||||
AiProvider::factory()->create(['provider' => 'elevenlabs', 'config' => ['voice_id' => 'v1']]);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'tts_voiceover']]);
|
||||
$step->update(['input' => ['text' => 'Hello and welcome']]);
|
||||
|
||||
$this->handler->handle($step->fresh(), $this->engine);
|
||||
|
||||
$fresh = $step->fresh();
|
||||
expect($fresh->status)->toBe('completed');
|
||||
expect($fresh->output['characters'])->toBe(strlen('Hello and welcome'));
|
||||
|
||||
$asset = \App\Models\Asset::find($fresh->output['asset_id']);
|
||||
expect($asset->type)->toBe('audio');
|
||||
expect($asset->mime_type)->toBe('audio/mpeg');
|
||||
expect(Storage::get($asset->disk_path))->toBe('fake-mp3-bytes');
|
||||
|
||||
Http::assertSent(fn ($request) => $request['text'] === 'Hello and welcome');
|
||||
});
|
||||
|
||||
test('it falls back to the latest script asset when no input text is given', function () {
|
||||
Http::fake(['api.elevenlabs.io/*' => Http::response('bytes')]);
|
||||
AiProvider::factory()->create(['provider' => 'elevenlabs', 'config' => ['voice_id' => 'v1']]);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$this->assets->store($project, 'script', 'Old draft', 'txt');
|
||||
$this->assets->store($project, 'script', 'Latest draft', 'txt');
|
||||
|
||||
$step = $this->engine->start($project, [['type' => 'tts_voiceover']]);
|
||||
|
||||
$this->handler->handle($step, $this->engine);
|
||||
|
||||
Http::assertSent(fn ($request) => $request['text'] === 'Latest draft');
|
||||
});
|
||||
|
||||
test('a voice_id in step input overrides the provider default', function () {
|
||||
Http::fake(['api.elevenlabs.io/*' => Http::response('bytes')]);
|
||||
AiProvider::factory()->create(['provider' => 'elevenlabs', 'config' => ['voice_id' => 'default-voice']]);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'tts_voiceover']]);
|
||||
$step->update(['input' => ['text' => 'hi', 'voice_id' => 'custom-voice']]);
|
||||
|
||||
$this->handler->handle($step->fresh(), $this->engine);
|
||||
|
||||
Http::assertSent(fn ($request) => str_contains($request->url(), '/text-to-speech/custom-voice'));
|
||||
});
|
||||
|
||||
test('it fails the step when there is no text to voice', function () {
|
||||
AiProvider::factory()->create(['provider' => 'elevenlabs', 'config' => ['voice_id' => 'v1']]);
|
||||
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'tts_voiceover']]);
|
||||
|
||||
$this->handler->handle($step, $this->engine);
|
||||
|
||||
expect($step->fresh())
|
||||
->status->toBe('failed')
|
||||
->error->toContain('No script text available');
|
||||
});
|
||||
|
||||
test('it fails the step when no active ElevenLabs provider is configured', function () {
|
||||
$project = VideoProject::factory()->create();
|
||||
$step = $this->engine->start($project, [['type' => 'tts_voiceover']]);
|
||||
$step->update(['input' => ['text' => 'hi']]);
|
||||
|
||||
$this->handler->handle($step->fresh(), $this->engine);
|
||||
|
||||
expect($step->fresh())
|
||||
->status->toBe('failed')
|
||||
->error->toContain('No active ElevenLabs provider');
|
||||
});
|
||||
Reference in New Issue
Block a user